Skip to content

Add job to package all platform artifacts into a single zip#17

Merged
jgeudens merged 5 commits intomasterfrom
claude/add-multi-platform-artifacts-zip-l4QoI
Apr 1, 2026
Merged

Add job to package all platform artifacts into a single zip#17
jgeudens merged 5 commits intomasterfrom
claude/add-multi-platform-artifacts-zip-l4QoI

Conversation

@jgeudens
Copy link
Copy Markdown
Member

@jgeudens jgeudens commented Apr 1, 2026

Adds a package job that runs after both linux and windows jobs
complete, downloads their artifacts, and bundles them into a single
modbusscope-all-platforms.zip artifact.

https://claude.ai/code/session_01KR8kVy6SZfAFds84XFTt6d

Summary by CodeRabbit

  • Chores
    • CI now consolidates Linux and Windows build outputs into a single combined release bundle for easier download and distribution.
  • Documentation
    • The user manual is now built and published as a downloadable PDF alongside the platform builds, and included in the combined release bundle.

claude added 2 commits April 1, 2026 09:36
Adds a `package` job that runs after both `linux` and `windows` jobs
complete, downloads their artifacts, and bundles them into a single
`modbusscope-all-platforms.zip` artifact.

https://claude.ai/code/session_01KR8kVy6SZfAFds84XFTt6d
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2d39f753-5457-4622-858f-9d411106ac17

📥 Commits

Reviewing files that changed from the base of the PR and between e3043ba and 1c9771f.

📒 Files selected for processing (1)
  • .github/workflows/ccpp.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/ccpp.yml

Walkthrough

Adds two new GitHub Actions jobs: docs builds the LaTeX user manual and uploads it as modbusscope-user-manual; package waits for linux, windows, and docs, downloads their artifacts, aggregates them under all-artifacts/, and uploads modbusscope-all-platforms.

Changes

Cohort / File(s) Summary
CI/CD Workflow
.github/workflows/ccpp.yml
Added docs job (runs in jgeudens/doc-latex:20250124_build_1 container) that builds docs, renames docs/manual/_build/latex/modbusscope.pdf to modbusscope-user-manual.pdf and uploads artifact modbusscope-user-manual; added package job (runs-on: ubuntu-latest, needs: [linux, windows, docs]) that downloads modbusscope-linux, modbusscope-windows, and modbusscope-user-manual into all-artifacts/ and uploads combined modbusscope-all-platforms.

Sequence Diagram(s)

sequenceDiagram
    participant LinuxJob as Linux build job
    participant WindowsJob as Windows build job
    participant DocsJob as Docs build job
    participant PackageJob as Package job
    participant ArtifactStore as GitHub Actions artifact storage

    LinuxJob->>ArtifactStore: upload `modbusscope-linux`
    WindowsJob->>ArtifactStore: upload `modbusscope-windows`
    DocsJob->>ArtifactStore: upload `modbusscope-user-manual`
    Note right of PackageJob: waits for LinuxJob, WindowsJob, DocsJob
    PackageJob->>ArtifactStore: download `modbusscope-linux` to all-artifacts/linux
    PackageJob->>ArtifactStore: download `modbusscope-windows` to all-artifacts/windows
    PackageJob->>ArtifactStore: download `modbusscope-user-manual` to all-artifacts/docs
    PackageJob->>PackageJob: assemble all artifacts under `all-artifacts/`
    PackageJob->>ArtifactStore: upload `modbusscope-all-platforms`
Loading
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding a packaging job that bundles platform artifacts into a single zip file, which directly matches the primary objective of the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/add-multi-platform-artifacts-zip-l4QoI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

jgeudens and others added 2 commits April 1, 2026 12:23
Co-authored-by: Jens Geudens <jensgeudens@hotmail.com>
Moves the PDF build into ccpp.yml as a `docs` job so the artifact is
accessible to the `package` job. doc.yml is kept as-is for standalone
doc builds.

https://claude.ai/code/session_01KR8kVy6SZfAFds84XFTt6d
@jgeudens jgeudens merged commit 77f791f into master Apr 1, 2026
10 checks passed
@jgeudens jgeudens deleted the claude/add-multi-platform-artifacts-zip-l4QoI branch April 1, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants